fix: clock source miss-match between Rust and Go#1742
Draft
Conversation
Metrics Change Detection
|
…irewood into es/replace-coarsetime
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Note: This PR will change after #1712 is merged.
coarsetime was introduced to avoid syscall overhead from
std::time, but @demosdemon confirmed (and we verified empirically) that std::time usesclock_gettime(CLOCK_MONOTONIC)via vDSO on modern Linux which is resolving in userspace with no kernel entry. The two are equivalent in cost.Removing coarsetime fixes the clock source mismatch between Rust
CLOCK_MONOTONIC_COARSEand GoCLOCK_MONOTONICthat was causing the Firewood dashboard to show Rust commit time higher than Go commit time, which is physically impossible since Go wraps Rust synchronously via CGO.How this works
Replaces all
coarsetime::Instant/coarsetime::Durationusages withstd::time::Instant/std::time::DurationHow this was tested
Full methodology in #1720.
Breaking Changes
commit_proposaltoken closure parameter type changes fromcoarsetime::Durationtostd::time::Duration