refactor!(core/types): Block method WithBody(Body) signature
#110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
force-pushed
the
qdm12/core/types/withbody
branch
from
801e855 to
c0f677c
Compare
qdm12
changed the title
BlockWithBodyOption variadic argument to Block.WithBodyWithExtra hook and InspectDatabase variadic options
ARR4N
reviewed
Jan 31, 2025
qdm12
force-pushed
the
qdm12/core/types/withbody
branch
from
c0f677c to
16cfcdf
Compare
qdm12
changed the title
WithExtra hook and InspectDatabase variadic optionsWithBody hook
ARR4N
changed the title
WithBody hookBlock.WithBody(*Body) signature
qdm12
force-pushed
the
qdm12/core/types/withbody
branch
from
16cfcdf to
9c584ab
Compare
ARR4N
requested changes
Feb 11, 2025
This was referenced Feb 11, 2025
qdm12
force-pushed
the
qdm12/core/types/withbody
branch
from
aef72be to
9f1862b
Compare
qdm12
commented
Feb 11, 2025
|
…drawals" This reverts commit b117d9a.
Thanks for this, somehow I totally omitted to write this which is kind of a big deal. |
ARR4N
added a commit
that referenced
this pull request
Feb 11, 2025
## Why this should be merged #110 introduces changes that we want to revert as part of the next Geth sync. This label will be applied to issues that track similar tasks. ## How this works Magic 🧙 ## How this was tested Inspecting [CI dry run, which creates the new label](https://github.com/ava-labs/libevm/actions/runs/13261362433/job/37018526246?pr=129#step:3:99). Signed-off-by: Arran Schlosberg <[email protected]>
ARR4N
approved these changes
Feb 11, 2025
| if bad.Header.Hash() == hash { | ||
| return types.NewBlockWithHeader(bad.Header).WithBody(bad.Body.Transactions, bad.Body.Uncles).WithWithdrawals(bad.Body.Withdrawals) | ||
| block := types.NewBlockWithHeader(bad.Header) | ||
| if bad.Body != nil { |
There was a problem hiding this comment.
(remark) This suggests that they thought the old version could have a nil-pointer dereference.
Co-authored-by: Arran Schlosberg <[email protected]> Signed-off-by: Quentin McGaw <[email protected]>
qdm12
changed the title
Block.WithBody(*Body) signatureBlock method WithBody(Body) signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change refactoring
core/types.Block.WithBody()method from signatureto signature
such that block and body extras can be used within
WithBody.Note
gethmade the same change in method signature so the deltas introduced in this PR will disappear once we sync.