chore(core/types): add Test_Body_hasOptionalFields to enforce hasLaterOptionalField is up to date

[qdm12]

Why this should be merged

To enforce updating the hasLaterOptionalField field if more optional fields are added to Body

How this works

Use some reflect magic in a unit test

How this was tested

[ARR4N]

Any fields added in the future will have to be optional. The change-detector will pick up on these too.

[qdm12]

The change-detector will pick up on these too.

yes but it would not pick up if we forget to update the hasLaterOptionalField expression. I thought about it working (/messing around) on the header, where we have many optional fields and the expression becomes an or of != nil checks.

[ARR4N]

Suggested change

	func (b *Body) hasOptionalFields() bool {
	func (b *Body) hasOptionalFieldsSet() bool {

[qdm12]

Renamed to hasAnyOptionalFieldSet since it should be true if any (not all) optional field is set.

[ARR4N]

This needs support for reflect.Pointer as the optional fields can be struct pointers.

[qdm12]

We can just add them later on a add-when-needed basis. If it's not defined in the switch, the test would fail

[ARR4N]

This will likely be made obsolete by #120

[ARR4N]

Unnecessary following merge of #120