refactor(core/types): Body backwards-compatibility out of package types_test
#131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARR4N
commented
Feb 12, 2025
ARR4N
commented
Feb 12, 2025
ARR4N
changed the title
Body backwards-compatibility tests into packageBody backwards-compatibility out of package types_test
qdm12
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Simplify testing in #130.
How this works
Backwards-compatibility tests were originally created in
package types_testbecause the first one usesethtestand would have caused a circular dependency. None of the later tests have this issue so they were moved intopackage types. Thecmpethtest utility isn't currently needed anywhere else so its functionality is collapsed inside this new file.How this was tested
N/A as simply moving existing tests to different files.