Skip to content

chore(ci): disable lint goheader step on non-pull-request events #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 17, 2025
Merged

chore(ci): disable lint goheader step on non-pull-request events #143

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b66471
chore(ci): disable lint workflow on pushes
qdm12 Feb 17, 2025
5323237
Only disable goheader step on non-pull-request events
qdm12 Feb 17, 2025
f2b4480
Revert unneeded change
qdm12 Feb 17, 2025
a097718
Pin golangci/golangci-lint-action to v6
qdm12 Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,12 @@ jobs:
with:
go-version-file: "go.mod"
- name: goheader
if: ${{ github.event_name == 'pull_request' }}
# The goheader linter is only enabled in the CI so that it runs only on modified or new files
# (see only-new-issues: true). It is disabled in .golangci.yml because
# golangci-lint running locally is not aware of new/modified files compared to the base
# commit of a pull request, and we want to avoid reporting invalid goheader errors.
uses: golangci/golangci-lint-action@ec5d18412c0aeab7936cb16880d708ba2a64e1ae # v6.2.0 since v6.3.1 does not handle `only-new-issues` correctly
uses: golangci/golangci-lint-action@v6
with:
version: v1.60
only-new-issues: true
Expand Down