feat(rlp/rlpgen): support alias types #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
types.Alias was only added in Go 1.22. |
qdm12
added
Status: 🔒 After next release
Welp, we'll wait for next geth sync I suppose 🤷 Please keep this opened, and I changed it back to a draft PR. |
|
You could bump the Go version to 1.22. We're going to be built with 1.23 anyway because of |
Merged
ARR4N
added a commit
that referenced
this pull request
Feb 25, 2025
## Why this should be merged `memsize` blocks usage of Go 1.23. We'll be building with 1.23 via `avalanchego` anyway (which doesn't transitively import `memsize`) so we want to run tests with the correct version. It will also unblock #154. ## How this works ✂️ We already cherry-pick the upstream commit (e467577) that removes `memsize` when on release branches so we instead do it ourselves and no longer cherry-pick. To avoid conflicts at the next `geth` sync, this PR should be reverted before performing the merge. See #128. ## How this was tested Existing tests.
ARR4N
removed
the
Status: 🔴 Blocked by Geth sync
ARR4N
added a commit
that referenced
this pull request
Feb 25, 2025
|
Merged |
ARR4N
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
To be able to generate RLP code using type aliases (defined e.g. in
coreth).This can and should be PR-ed upstream as well I think.
How this works
Call
types.Unalias()at the start ofbuildContext.makeOp(). The alternative of adding acaseto the switch statement adds unnecessary recursive calls whiletypes.Unalias()is a no-op if not an alias.How this was tested
New
rlpgenunit test with aliases of well-known types that have special handling—these make their proper handling easy to spot when inspecting generated code. A recursive alias in the same test also demonstrates full alias resolution.