Skip to content

Conversation

@qdm12
Copy link

@qdm12 qdm12 commented Mar 26, 2025

Why this should be merged

The documentation was lacking on how to create a new release tag, using newer automation tools developed.

How this works

Add readme.md in libevm/tooling/release and reference it in the root readme.md

How this was tested

Following each step to create https://github.com/ava-labs/libevm/releases/tag/v1.13.14-0.2.0.rc.4

The `myusername/release/v1.13.14-0.2.0.rc.4` branch will be used to add "release modifications" and will target the branch `release/v1.13.14-0.2.0.rc.4` in a pull request.
1. Run script `./cherrypick.sh` which cherry picks all Geth commits listed in [cherrypicks](cherrypicks)
- you may have to resolve conflicts
1. Modify [params/version.libevm.go](/params/version.libevm.go)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's useful to have this as the first step but NOT have anything committed. That way the version string is automatically generated for naming the release branch.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That way the version string is automatically generated for naming the release branch.

Through a test right?
I think it's best to keep it as it is, and have the CI check on the version string humanly typed, to avoid any bad copy-paste surprises.

@qdm12 qdm12 requested a review from ARR4N March 28, 2025 07:52
@ARR4N
Copy link
Collaborator

ARR4N commented May 22, 2025

Given @ceyonur's concerns with the repeated reviews required by this release pattern we'll probably deprecate it in favour of cherry-picking to main and reverting before upgrades (see commits listed in #128, which are effectively the same thing). I think we should move this PR to draft in the meantime.

@ARR4N
Copy link
Collaborator

ARR4N commented Jun 10, 2025

Closing as this approach was deprecated in #186 and #187.

@ARR4N ARR4N closed this Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants