fix(ci): go_tooling CI job git checkout tip of PR
#173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
commented
Mar 26, 2025
Signed-off-by: Quentin McGaw <[email protected]>
ARR4N
changed the title
go_tooling CI job git checkout tip of PR
ARR4N
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
The release-branch CI job tests branch properties of the
gitDAG but GitHub'sactions/checkoutby default creates a speculative merge commit against which PR CI is run. Running against this hypothetical situation makes the tests fail.How this works
actions/checkoutuses PR tipHow this was tested
Future run against a release branch.