feat: reentrancy.Guard for stateful precompiles
#212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARR4N
changed the title
PrecompileEnvironment.ReentrancyGuard()reentrancy.Guard
ARR4N
changed the title
reentrancy.Guardreentrancy.Guard for stateful precompiles
michaelkaplan13
approved these changes
Oct 3, 2025
There was a problem hiding this comment.
Makes sense and seems intuitive to use from a developer perspective.
The only example use case I can think of that the existing test doesn't cover is having multiple guards with different keys protecting different functions within a single precompile, and confirming calls to the other function can still be made.
Not strictly necessary for this PR though.
It was trivial to add so I included it. Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
The
vm.PrecompileEnvironment.Call()method requires careful usage because of reentrancy vulnerabilities (this is common to all outgoingCALLs in the EVM, not just stateful precompiles). This package provides a common method of protection, a reentrancy guard.How this works
Provides a function that returns
vm.ErrExecutionRevertedif called twice, by the same contract, in the same transaction, with the same identifier.How this was tested
Integration test.