Cherry pick eip 7951 #214
Cherry pick eip 7951 #214
Conversation
There was a problem hiding this comment.
Please separate the cherry-picking from the deletion of the old implementation, into 2 PRs. For cherry-picks we don't squash merge and simply fast-forward main as this maintains metadata integrity of the picked commit, making it possible to match the original and the pick. The cherry-pick branch therefore needs to have only the picked commit.
JonathanOppenheimer
force-pushed
the
cherry-pick-eip-7951
branch
from
8ad1941 to
861dca8
Compare
Got it - my apologies! I have broken them out into 2 different PRs. |
JonathanOppenheimer
force-pushed
the
cherry-pick-eip-7951
branch
from
861dca8 to
550c992
Compare
## Why this should be merged This PR removes the custom secp256 implementation in a single, seperate commit, as requested in #214
JonathanOppenheimer
force-pushed
the
cherry-pick-eip-7951
branch
2 times, most recently
from
904211b to
d7d19a6
Compare
|
I'm not sure why fjl isn't showing up as an author; have you picked the correct commit? It needs to be the one that was created when upstream merged their PR ( |
JonathanOppenheimer
force-pushed
the
cherry-pick-eip-7951
branch
from
d7d19a6 to
ba21474
Compare
|
I've re-cherry picked the commit and removed the additional Osaka registration. Let me know if it looks good now! |
ethereum/EIPs#9833 Based on ethereum#27540, ethereum#30043 --------- Co-authored-by: Ulaş Erdoğan <[email protected]>
JonathanOppenheimer
force-pushed
the
cherry-pick-eip-7951
branch
from
cecdbdc to
9e4c147
Compare
4 participants
Why this should be merged
RIP-7212 is superseded by EIP-7951 due to some security vulnerabilities discovered. Go-ethereum already implemented and merged the EIP, in PR ethereum#31991.
See avalanche-foundation/ACPs#223 for additional context.
How this was tested
The updated test-json package and unit test.