feat: Add support for named types with underlying basic types #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARR4N
requested changes
Oct 2, 2025
ARR4N
approved these changes
Oct 7, 2025
Signed-off-by: Ceyhun Onur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
The current rlpgen partially supports named types with basic underlying, and it generates the rlp without correct conversion i.e:
w.WriteUint64(obj.Uint64NewT)This PR adds the full support it
How this works
Adds check for
isNamedWithBasicUnderlyingand then returns aopwithmakeNamedBasicOpwhich is basically abasicOpbut with thetyprefers to the named type so that it can correctly encode decode with the named type.How this was tested
Added UT tests