feat: libevm/triedb/firewood scaffolding with proposal propagation
#237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alarso16
reviewed
Oct 2, 2025
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser | ||
| // General Public License for more details. | ||
| // | ||
| // You should have received a copy of the GNU Lesser General Public License |
There was a problem hiding this comment.
Is this the correct license for our firewood code?
alarso16
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Preparatory work for support of Firewood as a
triedb.DBOverride.How this works
trienodepackage haspseudopayloads added to nodes and sets, with hooks to allow the payloads to be propagated along with set mergers.NodeSetandMergedNodeSetpayloads are used to propagate Firewood proposal handles fromTrie.Commit()through totriedb.BackendDB.Update(), along with GC management to free Rust-owned proposals. THe handles are currently only dummies, used as plumbing.How this was tested
Integration tests of both (1) and (2). The
firewoodtests exercise the entire stack fromstate.StateDBdown totriedbbackend implementation (which will be Firewood).