feat: vm.PrecompiledStatefulContract can make CALLs
#40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the pattern used by `ava-labs/coreth` `NativeAssetCall`.
ARR4N
commented
Sep 29, 2024
| // | ||
| // ****** SECURITY ****** | ||
|
|
||
| var _ PrecompileEnvironment = (*evmCallArgs)(nil) |
There was a problem hiding this comment.
These have all been moved to the new environment type in environment.libevm.go.
ARR4N
commented
Sep 30, 2024
| return e.callContract(call, addr, input, gas, value, opts...) | ||
| } | ||
|
|
||
| func (e *environment) callContract(typ callType, addr common.Address, input []byte, gas uint64, value *uint256.Int, opts ...CallOption) ([]byte, uint64, error) { |
There was a problem hiding this comment.
This function is the primary implementation of the PR. Everything else was a necessary refactor to fix the Caller and Self addresses for the incoming call types.
ARR4N
requested review from
a team,
ceyonur,
darioush and
michaelkaplan13
and removed request for
a team
darioush
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Allow stateful precompiles to call other contracts; e.g. for
ava-labs/coreth'sNativeAssetCall.How this works
The
vm.PrecompileEnvironment.Call()method is added to mirrorvm.EVM.Call()in behaviour and in all syntax except the first argument,caller—the caller is the precompile itself, which is deterministic. An option to override the caller is included for backwards compatibility withNativeAssetCallbut it MUST NOT otherwise be used.Determining the correct
ContractRefto use as thecalleruncovered existing bugs in thelibevm.AddressContextvalues passed to the precompile. Specifically, theSelfandCalleraddresses underCallCode()andDelegateCall()invocation of the precompile were incorrect. These are fixed via a refactor to abstract env behaviour into a newenvironmenttype although most of this is existing code just in a new file. Note that this fix means that stateful precompiles now behave as Solidity developers expect (other than #41).The
evmCallArgsfield for read-write inheritance is replaced with a call-type field that indicates theEVMmethod through which the precompile was invoked. This implies RW inheritance (i.e.StaticCall()vs not) while also allowing other behaviour and simplifying the construction of anevmCallArgs.How this was tested
An integration test exercises typical behaviour of a precompile calling another contract: origin (EOA) -> regular bytecode contract -> precompile -> any other contract. This demonstrates plumbing of data as well as correct setting of the
caller.The existing test of new precompiles is updated to demonstrate the fix of the
AddressContextvalues.