fix: vm.WithUNSAFECallerAddressProxying under DELEGATECALL
#50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Correct backwards compatibility for
ava-labs/corethNativeAssetCall(NAC).How this works
NACalways acted as if it were its actual caller, not its effective caller under EVM rules. AsDelegateCallmodifies both the effective self and caller addresses, theWithUNSAFECallerAddressProxying()option now properly selects the actual caller to use when making outgoing calls.In addition to proxying its actual-caller address on outbound calls,
NACcharged the actual caller of the precompile. To discern this, theCallTypeis made available viaPrecompileEnvironment. See the example code for how to determine the actual caller.How this was tested
Additional test cases for
TestPrecompileMakeCallas this asserts the addresses as seen by the contract called by the precompile.