refactor!: consolidate params and types payload access
#84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARR4N
requested review from
a team,
ceyonur,
darioush and
michaelkaplan13
and removed request for
a team
darioush
approved these changes
Dec 9, 2024
ARR4N
added a commit
that referenced
this pull request
Dec 9, 2024
## Why this should be merged Consolidates duplicated logic. Similar rationale to #84. ## How this works New `register.AtMostOnce[T]` type is responsible for limiting calls to `Register()`. ## How this was tested Existing unit tests of `params`. Note that the equivalent functionality in `types` wasn't tested but now is.
ARR4N
changed the title
params and types payload accessparams and types payload access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
There are 3 places at which we perform the same, sensitive logic to access registered payloads and as we modify more types this is likely to expand. (e.g.
types.Header).How this works
Introduces
pseudo.Accessorto abstract the reusable code.How this was tested
Existing unit tests. Note that the
types.StateAccounttests needed a minor refactor to provide the assertions with access to theExtraPayloads[T]without introducing generic types anywhere.