Skip to content

Conversation

@qdm12
Copy link

@qdm12 qdm12 commented Dec 18, 2024

Why this should be merged

Github issues are currently using the default github labels, and it would be good to have custom and easily customizable-as-code Github labels to better categorize Github issues.

How this works

  • New workflow labels.yml using crazy-max/ghaction-github-labeler to have Github labels as code in .github/labels.yml
  • Custom labels defined in .github/labels.yml. Note:
    • default old ones will all be removed, except migrated ones below:
    • bug label will be migrated to Category: Bug 🐛 label
    • DO NOT MERGE label will be migrated to Status: 🔴 DO NOT MERGE
  • Dry run the labels job on pull requests affecting labels configuration files
  • New workflow labels-skip.yml to satisfy required workflow passing for pull requests (not set yet but should be set soon), triggering only on pull requests and when none of the labels related files are modified. This can be removed eventually as well, since we don't really need to make the labels workflow a required workflow, but I think it's a good-to-know at least during the PR review 😉 Also note it runs on every commit here since .github/workflows/labels-skip.yml is not part of the ignored paths.

How this was tested

Dry run on this pull request

@qdm12 qdm12 marked this pull request as ready for review December 18, 2024 11:33
@qdm12 qdm12 changed the title chore(ci): define Github labels with a workflow chore(ci): define Github labels as code with a workflow Dec 18, 2024
@qdm12 qdm12 requested a review from ARR4N December 18, 2024 14:07
Copy link
Collaborator

@ARR4N ARR4N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending #95 into this branch as it's easier than a review.

Easier than PR suggestions. I noticed that some useful labels were being
deleted either entirely or to be replaced with effectively the same
thing.

---------

Signed-off-by: Arran Schlosberg <[email protected]>
Co-authored-by: Quentin McGaw <[email protected]>
@qdm12 qdm12 merged commit bee85d6 into main Dec 23, 2024
5 checks passed
@qdm12 qdm12 deleted the qdm12/github-labels branch December 23, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants