updated template to use updated add log function #1587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanOppenheimer
force-pushed
the
update-template-to-use-updated-add-log-function
branch
from
ae67e23 to
12d530c
Compare
|
Hey @yashgo0018 - we request that all PRs pass all unit tests, and that commits are signed. Please let me know if you have any questions. |
yashgo0018
force-pushed
the
update-template-to-use-updated-add-log-function
branch
from
d32c823 to
7ffc876
Compare
Hi @JonathanOppenheimer, I have signed the commit now, along with rebasing the commit to be on top of master. |
JonathanOppenheimer
approved these changes
Sep 26, 2025
Approved - feel free to update the PR description if desired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Add log function's interface is updated but the template file for generating a new pre compile was not updated to support the new format. This PR is resolving that.