Skip to content

sync: coreth PR #1149: add precompile reversion logic for Granite activation #1761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 7, 2025
Merged

sync: coreth PR #1149: add precompile reversion logic for Granite activation #1761

merged 14 commits into from
Oct 7, 2025
+196 −5

Conversation

JonathanOppenheimer
Copy link
Member

@JonathanOppenheimer JonathanOppenheimer commented Sep 30, 2025 •
edited
Loading

Syncs ava-labs/coreth#1149.

  • Requesting Michael for review as he was the first approver
  • Requesting Austin for review as he was the second approver.

JonathanOppenheimer and others added 2 commits September 30, 2025 13:22
@JonathanOppenheimer @ceyonur
@ARR4N @StephenButtolph
Add precompile reversion logic for Granite activation (#1149)
d3baff7 
Signed-off-by: Jonathan Oppenheimer <[email protected]>
Signed-off-by: Jonathan Oppenheimer <[email protected]>
Co-authored-by: Ceyhun Onur <[email protected]>
Co-authored-by: Arran Schlosberg <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]>
@JonathanOppenheimer
resolve some errors
f4ec0ae
@JonathanOppenheimer JonathanOppenheimer self-assigned this Sep 30, 2025
JonathanOppenheimer
JonathanOppenheimer commented Oct 6, 2025
View reviewed changes
JonathanOppenheimer
JonathanOppenheimer commented Oct 6, 2025
View reviewed changes
JonathanOppenheimer
JonathanOppenheimer commented Oct 6, 2025
View reviewed changes
@JonathanOppenheimer JonathanOppenheimer marked this pull request as ready for review October 6, 2025 17:57
@JonathanOppenheimer JonathanOppenheimer requested a review from a team as a code owner October 6, 2025 17:57
@JonathanOppenheimer
Copy link
Member Author

This PR is blocked on #1765, as we have to set the cost of granite transactions to 0, (which we do in this PR to show that the new test case added passes). However this breaks a lot of other test cases which we fix in #1765.
Screenshot 2025-10-06 at 2 05 58 PM

michaelkaplan13
michaelkaplan13 reviewed Oct 7, 2025
View reviewed changes
ceyonur
ceyonur previously requested changes Oct 7, 2025
View reviewed changes
ceyonur
ceyonur reviewed Oct 7, 2025
View reviewed changes
@ceyonur ceyonur added this pull request to the merge queue Oct 7, 2025
Merged via the queue into master with commit d3bb8a5 Oct 7, 2025
13 checks passed
@ceyonur ceyonur deleted the JonathanOppenheimer/sync-pr-1149-revert-precompile-behavior branch October 7, 2025 19:16
powerslider pushed a commit that referenced this pull request Oct 8, 2025
@JonathanOppenheimer @ceyonur
@ARR4N @StephenButtolph @powerslider
sync: coreth PR #1149: add precompile reversion logic for Granite act…
7c1de96 
…ivation (#1761)

Signed-off-by: Jonathan Oppenheimer <[email protected]>
Signed-off-by: Jonathan Oppenheimer <[email protected]>
Co-authored-by: Ceyhun Onur <[email protected]>
Co-authored-by: Arran Schlosberg <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ceyonur ceyonur ceyonur approved these changes

@alarso16 alarso16 Awaiting requested review from alarso16

@michaelkaplan13 michaelkaplan13 Awaiting requested review from michaelkaplan13

Assignees

@JonathanOppenheimer JonathanOppenheimer

Labels

coreth sync

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JonathanOppenheimer @ceyonur @michaelkaplan13