chore(customrawdb): delete customrawdb package and switch to avalanchego imports #1781
+161
−822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ego imports resolves #17791 Signed-off-by: Tsvetan Dimitrov ([email protected])
powerslider
force-pushed
the
powerslider/1779-delete-customrawdb-package
branch
from
901b225 to
0825b78
Compare
…ilize chain config I/O - Alias libevm metrics import to evmmetrics and update usages to avoid symbol collision with local metrics in the network and network/stats packages. - Pass a copied extras object into customrawdb ReadChainConfig/WriteChainConfig to avoid data races and shared-mutation bugs under new avalanchego versions.
- Also modify Dockerfile to isolate the avalanchego source to not become part of the build context of the main project. - Revert the previous docker related changes.
powerslider
force-pushed
the
powerslider/1779-delete-customrawdb-package
branch
from
a4b29c5 to
517b563
Compare
- Read stored config using a local copy of extras to avoid data races. - Still write using the attached extras to persist upgrade bytes. - Re-read with a fresh copy for compatibility comparison.
…ocal avalanchego, sort comm inputs
- core/genesis:
- Persist upgrade bytes only when height == 0, otherwise write after compatibility check passes.
- Reconcile precompile-only incompatibilities by persisting upgrade metadata and proceeding.
- docker:
- Only move and replace local avalanchego when it’s a standalone module (./avalanchego/go.mod), avoiding accidental source flattening.
- scripts:
- Sort right-hand inputs to comm in build_test.sh and lint_allowed_eth_imports.sh to eliminate “comm: input is not in sorted order”.
powerslider
force-pushed
the
powerslider/1779-delete-customrawdb-package
branch
3 times, most recently
from
a621e73 to
79557f4
Compare
- Move ./avalanchego to /third_party if present. - Always dropreplace first; conditionally add replace if go.mod exists. - Run go mod tidy after edits.
powerslider
force-pushed
the
powerslider/1779-delete-customrawdb-package
branch
from
79557f4 to
e9ecb8c
Compare
powerslider
added
the
state-sync-migration
Co-authored-by: Austin Larson <[email protected]> Co-authored-by: Michael Kaplan <[email protected]>
…ilable gas capacity (#1772)
Co-authored-by: Michael Kaplan <[email protected]>
Co-authored-by: Ceyhun Onur <[email protected]>
…ivation (#1761) Signed-off-by: Jonathan Oppenheimer <[email protected]> Signed-off-by: Jonathan Oppenheimer <[email protected]> Co-authored-by: Ceyhun Onur <[email protected]> Co-authored-by: Arran Schlosberg <[email protected]> Co-authored-by: Stephen Buttolph <[email protected]>
|
Added a DO NOT MERGE label until ava-labs/avalanchego#4387 is merged. |
powerslider
added
the
DO NOT MERGE
|
I will review post AvalancheGo merger and when this PR is updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Check #1779
How this works
plugin/evm/customrawdb.github.com/ava-labs/avalanchego/vms/evm/sync/customrawdbimport instead.Necessary changes to adapt to the newest
avalanchegoversion and the migratedcustomrawdbpackage:reconcileCompatibility,persistChainConfigAndReload,logCompatibilityMismatch).subnet-evm's build context. Prevents Docker builds from accidentally flatteningavalanchegosources or failing on missinggo.mod.build_test.shandlint_allowed_eth_imports.shto avoidinput is not in sorted orderHow this was tested
existing tests and successful build
Need to be documented?
no
Need to update RELEASES.md?
no
resolves #1779
Signed-off-by: Tsvetan Dimitrov ([email protected])