Skip to content

sync: coreth PR #1173: fix: free memory used by proposals in firewood #1782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2025
+7 −2
Merged

sync: coreth PR #1173: fix: free memory used by proposals in firewood #1782

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
317323d
fix: free memory used by proposals in firewood (#1173)
demosdemon Sep 15, 2025
ea8ca89
Merge branch 'master' into JonathanOppenheimer/prevent-firewood-memor…
JonathanOppenheimer Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions triedb/firewood/database.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,10 +376,15 @@ func (db *Database) Close() error {
db.proposalLock.Lock()
defer db.proposalLock.Unlock()

// We don't need to explicitly dereference the proposals, since they will be cleaned up
// within the firewood close method.
// before closing, we must deference any outstanding proposals to free the
// memory owned by firewood (outside of go's memory management)
for _, pCtx := range db.proposalTree.Children {
db.dereference(pCtx)
}

db.proposalMap = nil
db.proposalTree.Children = nil

// Close the database
return db.fwDisk.Close()
}
Expand Down