Skip to content

sync: coreth PR #1292: ACP-226: min block delay verify #1808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

sync: coreth PR #1292: ACP-226: min block delay verify #1808

wants to merge 4 commits into from
+203 −82

Conversation

ceyonur
Copy link
Collaborator

@ceyonur ceyonur commented Oct 14, 2025

Why this should be merged

Syncs ava-labs/coreth#1292

@ceyonur @michaelkaplan13
ACP-226: min block delay verify (#1292)
a1af1bc 
Signed-off-by: Ceyhun Onur <[email protected]>
Signed-off-by: Ceyhun Onur <[email protected]>
Co-authored-by: Michael Kaplan <[email protected]>
@ceyonur ceyonur changed the title ACP-226: min block delay verify (#1292) ACP-226: min block delay verify (Coreth#1292) Oct 14, 2025
@ceyonur ceyonur self-assigned this Oct 14, 2025
ceyonur
ceyonur commented Oct 14, 2025
View reviewed changes
@ceyonur ceyonur marked this pull request as ready for review October 14, 2025 12:03
@ceyonur ceyonur requested a review from a team as a code owner October 14, 2025 12:03
michaelkaplan13
michaelkaplan13 approved these changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@michaelkaplan13 michaelkaplan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code & tests look correct to me (and matches coreth changes)...I'm just wondering why the vm_test.go changes from the earlier block builder sync weren't brought in 1-1 in their corresponding subnet-evm PRs?

@JonathanOppenheimer JonathanOppenheimer changed the title ACP-226: min block delay verify (Coreth#1292) sync: coreth PR #1292: ACP-226: min block delay verify Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelkaplan13 michaelkaplan13 michaelkaplan13 approved these changes

@alarso16 alarso16 alarso16 approved these changes

Assignees

@ceyonur ceyonur

Labels

acp226 coreth sync

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ceyonur @michaelkaplan13 @alarso16