When record is nested by a non-record type (e.g. interface) use simple builder name#97
Merged
When record is nested by a non-record type (e.g. interface) use simple builder name#97
Conversation
…e builder name With #67 all records that were nested inside ANY type had a builder name in the form: <enclosedTypeShortName>$<recordShortName>Builder This change checks the enclosed type and if it is NOT a record type (say an interface) then just use the simple builder name in the form: <recordShortName>Builder For record types that are nested inside a record type the current behaviour remains and the generated builders get the full unique name that includes the enclosed type short name. The use case triggering this change is where the records are defined in an interface type (for an http client).
SentryMan
approved these changes
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #67 all records that were nested inside ANY type had a builder name in the form:
<enclosedTypeShortName>$<recordShortName>BuilderThis change checks the enclosed type and if it is NOT a record type (say an interface) then just use the simple builder name in the form:
<recordShortName>BuilderFor record types that are nested inside a record type the current behaviour remains and the generated builders get the full unique name that includes the enclosed type short name.
The use case triggering this change is where the records are defined in an interface type (for an http client).