fix: surface glob errors and enforce t.try() guard rails issue #3407 #3408
+49
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When Api.run() fails to glob test files (for instance because projectDir points to a file), AVA crashes with TypeError: Cannot read properties of undefined (reading 'length'). This happens before AVA can emit the actual glob error. Similarly, t.try() guard rails throw undefined when users call commit() after discard() (or vice versa), instead of surfacing the intended error.
Steps to reproduce
Expected behavior
Actual behavior
Why it matters
Both bugs hide the user-facing error. Glob misconfiguration looks like an AVA crash, and t.try() misuse is nearly impossible todiagnose because the error message disappears.
Proposed fix