fix: surface glob errors and enforce t.try() guard rails issue #3407

lib/api.js

@@ -146,7 +146,7 @@ export default class Api extends Emittery {
 
 		const {providers = []} = this.options;
 
-		let testFiles;
+		let testFiles = [];
 		try {
 			testFiles = await globs.findTests({cwd: this.options.projectDir, ...apiOptions.globs});
 			if (typeof testFileSelector === 'function') {

lib/test.js

@@ -135,7 +135,7 @@ class ExecutionContext extends Assertions {
 
 					if (discarded) {
 						test.saveFirstError(new Error('Can’t commit a result that was previously discarded'));
-						throw this.testFailure;
+						throw test.testFailure;
 					}
 
 					committed = true;
@@ -154,7 +154,7 @@ class ExecutionContext extends Assertions {
 				discard({retainLogs = false} = {}) {
 					if (committed) {
 						test.saveFirstError(new Error('Can’t discard a result that was previously committed'));
-						throw this.testFailure;
+						throw test.testFailure;
 					}
 
 					if (discarded) {

test-tap/api.js

@@ -33,6 +33,27 @@ const options = [
 ];
 
 for (const opt of options) {
+	test(`propagates glob errors - workerThreads: ${opt.workerThreads}`, async t => {
+		const invalidProjectDir = path.join(__dirname, 'fixture', 'fail-fast', 'single-file', 'test.cjs');
+		const api = await apiCreator({
+			...opt,
+			projectDir: invalidProjectDir,
+		});
+
+		const errors = [];
+		api.on('run', plan => {
+			plan.status.on('stateChange', event => {
+				if (event.type === 'internal-error') {
+					errors.push(event.err);
+				}
+			});
+		});
+
+		const runStatus = await api.run();
+		t.equal(runStatus.stats.internalErrors, 1);
+		t.equal(errors.length, 1);
+		t.match(errors[0].message, /cwd.*directory/);
+	});
 	test(`fail-fast mode - workerThreads: ${opt.workerThreads} - single file & serial`, async t => {
 		const api = await apiCreator({
 			...opt,

test/multiple-implementations/fixtures/try-guards.js

@@ -0,0 +1,19 @@
+import test from 'ava';
+
+test('commit after discard throws', async t => {
+	const attempt = await t.try(tt => {
+		tt.pass();
+	});
+
+	attempt.discard();
+	attempt.commit();
+});
+
+test('discard after commit throws', async t => {
+	const attempt = await t.try(tt => {
+		tt.pass();
+	});
+
+	attempt.commit();
+	attempt.discard();
+});

test/multiple-implementations/test.js

@@ -11,3 +11,9 @@ test('t.try()', async t => {
 	const result = await t.throwsAsync(fixture(['try.js']));
 	t.regex(result.stdout, /Expected an implementation/);
 });
+
+test('t.try() guardrails report errors', async t => {
+	const result = await t.throwsAsync(fixture(['try-guards.js']));
+	t.regex(result.stdout, /Can’t commit a result that was previously discarded/);
+	t.regex(result.stdout, /Can’t discard a result that was previously committed/);
+});