Open
Conversation
Owner
avdv
commented
Jun 18, 2024
- Move terminal width implementation to C
- ninja: No longer skip scala-native windows sources
- ninja: Link to dbghelp when platform is Windows
- ninja: Monkey patch windows/time.c
- Add win32 compat hack
- Add x86_64 windows target
- CI: Add run windows executable step
Makes it easier to deal with win32 / unix differences.
Otherwise, this would fail compilation because of the defines, and linking because of duplicate symbols for tzset.
This adds missing scalanative C functions that are actually supported on win32 but are restricted to compilation without _WIN32 defined, or adds stubs for functions that are not actually supported on Windows.
b302218 to
cb3741c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.