Skip to content

Comments

add protoc-gen-httpgo to Generators section#6004

Open
MUlt1mate wants to merge 1 commit intoavelino:mainfrom
MUlt1mate:httpgo
Open

add protoc-gen-httpgo to Generators section#6004
MUlt1mate wants to merge 1 commit intoavelino:mainfrom
MUlt1mate:httpgo

Conversation

@MUlt1mate
Copy link

We want to ensure high quality of the packages. Make sure that you've checked the boxes below before sending a pull request.

Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.

  • The repo documentation has a pkg.go.dev link.
  • The repo documentation has a coverage service link. see below
  • The repo documentation has a goreportcard link.
  • The repo has a version-numbered release and a go.mod file.
  • The repo has a continuous integration process that automatically runs tests that must pass before new pull requests are merged.
  • Continuous integration is used to attempt to catch issues prior to releasing this package to end-users.

Please provide some links to your package to ease the review

Pull Request content

  • The package has been added to the list in alphabetical order.
  • The package has an appropriate description with correct grammar.
  • As far as I know, the package has not been listed here before.

Category quality

Note that new categories can be added only when there are 3 packages or more.

Packages added a long time ago might not meet the current guidelines anymore. It would be very helpful if you could check 3-5 packages above and below your submission to ensure that they also still meet the Quality Standards.

Please delete one of the following lines:

  • The packages around my addition still meet the Quality Standards.

Thanks for your PR, you're awesome! 😎

Coverage note

The main module shows low coverage (approx. 2%) because standard coverage tools struggle to track execution within a protoc plugin lifecycle. Since the core logic involves generating Go source code and passing it back to the Protobuf compiler, traditional unit tests on the generator's internals are less effective than verifying the end result.

Instead of internal unit tests, I use a integration driven approach located in the example module.
What it does:

  • generates HTTP servers/clients from a wide variety of .proto definitions.
  • ensures the generated code compiles without errors.
  • runs a bunch of unit and integration tests against the generated code to ensure the HTTP handlers, middlewares, and marshaling logic work as intended.

It runs within CI/CD and can be run local with make test and make run commands

@github-actions
Copy link

Automated Quality Checks (from CONTRIBUTING minimum standards)

  • Repo: OK
  • pkg.go.dev: OK
  • goreportcard: OK (grade unknown)
  • coverage: missing

These checks are a best-effort automation and do not replace human review.

@MUlt1mate
Copy link
Author

Can someone please take a look at this PR and tell if my excuse for absent coverage is acceptable?
@phanirithvij hi! Sorry, you seem to be an active maintainer here. Can you help me?

@harmonseam-max
Copy link

harmonseam-max commented Jan 26, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants