add protoc-gen-httpgo to Generators section#6004
Open
MUlt1mate wants to merge 1 commit intoavelino:mainfrom
Open
add protoc-gen-httpgo to Generators section#6004MUlt1mate wants to merge 1 commit intoavelino:mainfrom
MUlt1mate wants to merge 1 commit intoavelino:mainfrom
Conversation
|
Automated Quality Checks (from CONTRIBUTING minimum standards)
These checks are a best-effort automation and do not replace human review. |
Author
|
Can someone please take a look at this PR and tell if my excuse for absent coverage is acceptable? |
|
Yes
…On Mon, Jan 26, 2026 at 10:33 AM Mikhail ***@***.***> wrote:
*MUlt1mate* left a comment (avelino/awesome-go#6004)
<#6004 (comment)>
Can someone please take a look at this PR and tell if my excuse for absent
coverage is acceptable?
@phanirithvij <https://github.com/phanirithvij> hi! Sorry, you seem to be
an active maintainer here. Can you help me?
—
Reply to this email directly, view it on GitHub
<#6004 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/B4SEDN4GS2PNH75PS6MMV234IXNOLAVCNFSM6AAAAACSVCBVKWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOOJYGY2DMNRWGY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to ensure high quality of the packages. Make sure that you've checked the boxes below before sending a pull request.
Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.
Please provide some links to your package to ease the review
Pull Request content
Category quality
Note that new categories can be added only when there are 3 packages or more.
Packages added a long time ago might not meet the current guidelines anymore. It would be very helpful if you could check 3-5 packages above and below your submission to ensure that they also still meet the Quality Standards.
Please delete one of the following lines:
Thanks for your PR, you're awesome! 😎
Coverage note
The main module shows low coverage (approx. 2%) because standard coverage tools struggle to track execution within a protoc plugin lifecycle. Since the core logic involves generating Go source code and passing it back to the Protobuf compiler, traditional unit tests on the generator's internals are less effective than verifying the end result.
Instead of internal unit tests, I use a integration driven approach located in the example module.
What it does:
It runs within CI/CD and can be run local with
make testandmake runcommands