Add system that asserts physics components are finite#909
Merged
Jondolf merged 2 commits intoavianphysics:mainfrom Dec 28, 2025
Merged
Add system that asserts physics components are finite#909Jondolf merged 2 commits intoavianphysics:mainfrom
Jondolf merged 2 commits intoavianphysics:mainfrom
Conversation
janhohenheim
approved these changes
Dec 19, 2025
janhohenheim
added
C-Usability
Aceeri
approved these changes
Dec 28, 2025
Jondolf
reviewed
Dec 28, 2025
Jondolf
approved these changes
Dec 28, 2025
Wiwip
pushed a commit
to Wiwip/avian
that referenced
this pull request
Dec 29, 2025
A lot of people (me included) have had to track down NaNs or infinities that causes avian internals to crash, and they can be difficult to track down because they cause crashes a lot later than they are introduced. Add a system when running with debug assertions that checks relevant components during `PhysicsSystems::First`. For bugs in Avian internals we can potentially also schedule this system in other places. * I placed it in `PhysicsSchedulePlugin` because it feels more general purpose than the rest of `PhysicsDebugPlugin` and because it needs `self.schedule`, but I'm not sure if that's the best location for it? * We could make the system use `assert!` instead of `debug_assert!` and make it runnable outside of `debug_assertions`? I modified one of the examples to introduce an infinity during Update and saw that it was caught. Added mass query data accessor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
A lot of people (me included) have had to track down NaNs or infinities that causes avian internals to crash, and they can be difficult to track down because they cause crashes a lot later than they are introduced.
Solution
Add a system when running with debug assertions that checks relevant components during
PhysicsSystems::First.For bugs in Avian internals we can potentially also schedule this system in other places.
Questions
PhysicsSchedulePluginbecause it feels more general purpose than the rest ofPhysicsDebugPluginand because it needsself.schedule, but I'm not sure if that's the best location for it?assert!instead ofdebug_assert!and make it runnable outside ofdebug_assertions?Testing
I modified one of the examples to introduce an infinity during Update and saw that it was caught.