Allow selecting active service cards #226
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| <template id="tpl-service-item"> | ||
| <div class="service-item"> | ||
| <div class="service-item" tabindex="0"> |
There was a problem hiding this comment.
[P1] Add tabindex when service cards built in JS
Setting tabindex="0" on the template does not make the rendered service cards focusable because audits/scripts/viewer.js constructs each card via document.createElement('div') and never clones the template. In the deployed page the cards still lack a tabindex, so keyboard users cannot focus them and the new :focus-within outline never appears. The JavaScript render path needs to apply the same tabindex (or use the template) for the accessibility change to take effect.
Useful? React with 👍 / 👎.
Summary
Testing
./tests/run.shhttps://chatgpt.com/codex/tasks/task_e_68b08ee929dc832d95ba6c9070f86cc2