Skip to content

Harden fuzz checks for range int arrays #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aviggiano merged 5 commits into from
Dec 29, 2025
Merged

Harden fuzz checks for range int arrays #138

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f9fa4b9
Strengthen fuzz coverage for range int arrays
aviggiano Dec 28, 2025
cb4e5fe
Expand fuzz invariants for bitmap APIs
aviggiano Dec 29, 2025
ef17d3c
Update tests/fuzz/fuzz_common.h
aviggiano Dec 29, 2025
7a9e463
Update tests/fuzz/fuzz_common.h
aviggiano Dec 29, 2025
7116ff6
Update tests/fuzz/fuzz_common.h
aviggiano Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 73 additions & 10 deletions tests/fuzz/fuzz_bitmap64_api.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,14 @@ int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {

switch (op) {
case OP_SETBIT: {
uint64_t offset = fuzz_consume_u64_in_range(&input, 0, MAX_BIT_OFFSET_64);
uint64_t offset = fuzz_consume_bool(&input)
? 0
: fuzz_consume_u64_in_range(&input, 0, MAX_BIT_OFFSET_64);
bool value = fuzz_consume_bool(&input);
bitmap64_setbit(bitmap, offset, value);
bool prev = bitmap64_getbit(bitmap, offset);
bool ret = bitmap64_setbit(bitmap, offset, value);
fuzz_require(ret == prev);
fuzz_require(bitmap64_getbit(bitmap, offset) == value);
break;
}

Expand All @@ -49,6 +54,11 @@ int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
size_t array_size;
uint64_t* array = generate_uint64_array(&input, &array_size);
if (array && array_size > 0) {
if (fuzz_consume_bool(&input)) {
array[0] = 0;
if (array_size > 1) array[1] = 8;
if (array_size > 2) array[2] = 16;
}
Bitmap64* new_bitmap = bitmap64_from_int_array(array_size, array);
if (new_bitmap) {
bitmap64_free(bitmap);
Expand All @@ -63,8 +73,11 @@ int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
/* Only get array if cardinality is reasonable */
uint64_t card = bitmap64_get_cardinality(bitmap);
if (card > 0 && card < MAX_SAFE_CARDINALITY) {
size_t result_size;
uint64_t result_size;
uint64_t* result = bitmap64_get_int_array(bitmap, &result_size);
if (card <= MAX_RANGE_VALIDATE_CARDINALITY) {
fuzz_check_int_array64(bitmap, result, result_size);
}
safe_free(result);
}
break;
Expand All @@ -74,6 +87,11 @@ int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
size_t array_size;
uint64_t* array = generate_uint64_array(&input, &array_size);
if (array && array_size > 0) {
if (fuzz_consume_bool(&input)) {
array[0] = 0;
if (array_size > 1) array[1] = 8;
if (array_size > 2) array[2] = 16;
}
Bitmap64* new_values = bitmap64_from_int_array(array_size, array);
if (new_values) {
roaring64_bitmap_or_inplace(bitmap, new_values);
Expand All @@ -87,10 +105,18 @@ int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
case OP_RANGEINTARRAY: {
uint64_t card = bitmap64_get_cardinality(bitmap);
if (card > 0) {
size_t start = fuzz_consume_size_in_range(&input, 0, card);
size_t end = fuzz_consume_size_in_range(&input, start, card + 100);
size_t result_count;
uint64_t start = 0;
uint64_t end = 0;
if ((card >= 3) && fuzz_consume_bool(&input)) {
start = 0;
end = 2;
} else {
start = fuzz_consume_u64_in_range(&input, 0, card);
end = fuzz_consume_u64_in_range(&input, start, card + 100);
}
uint64_t result_count;
uint64_t* result = bitmap64_range_int_array(bitmap, start, end, &result_count);
fuzz_check_range_int_array64(bitmap, start, end, result, result_count);
safe_free(result);
}
break;
Expand All @@ -102,6 +128,9 @@ int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
if (bit_array && bit_array_size > 0) {
Bitmap64* new_bitmap = bitmap64_from_bit_array(bit_array_size, bit_array);
if (new_bitmap) {
if (bit_array_size <= MAX_BITARRAY_VALIDATE_SIZE) {
fuzz_check_input_bit_array64(new_bitmap, bit_array, bit_array_size);
}
bitmap64_free(bitmap);
bitmap = new_bitmap;
}
Expand All @@ -117,6 +146,9 @@ int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
if (max_val < MAX_BIT_OFFSET_64) {
size_t result_size;
char* bit_array = bitmap64_get_bit_array(bitmap, &result_size);
if (result_size <= MAX_BITARRAY_VALIDATE_SIZE) {
fuzz_check_bit_array64(bitmap, bit_array, result_size);
}
bitmap_free_bit_array(bit_array);
}
}
Expand Down Expand Up @@ -195,14 +227,28 @@ int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {

case OP_MIN: {
if (!bitmap64_is_empty(bitmap)) {
bitmap64_min(bitmap);
uint64_t min = bitmap64_min(bitmap);
uint64_t card = bitmap64_get_cardinality(bitmap);
if (card > 0 && card <= MAX_RANGE_VALIDATE_CARDINALITY) {
bool found = false;
uint64_t expected = bitmap64_get_nth_element_present(bitmap, 1, &found);
fuzz_require(found);
fuzz_require(min == expected);
}
}
break;
}

case OP_MAX: {
if (!bitmap64_is_empty(bitmap)) {
bitmap64_max(bitmap);
uint64_t max = bitmap64_max(bitmap);
uint64_t card = bitmap64_get_cardinality(bitmap);
if (card > 0 && card <= MAX_RANGE_VALIDATE_CARDINALITY) {
bool found = false;
uint64_t expected = bitmap64_get_nth_element_present(bitmap, card, &found);
fuzz_require(found);
fuzz_require(max == expected);
}
}
break;
}
Expand Down Expand Up @@ -239,6 +285,11 @@ int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
offsets[i] = fuzz_consume_u64_in_range(&input, 0, MAX_BIT_OFFSET_64);
}
bool* results = bitmap64_getbits(bitmap, n_offsets, offsets);
if (results) {
for (size_t i = 0; i < n_offsets; i++) {
fuzz_require(results[i] == bitmap64_getbit(bitmap, offsets[i]));
}
}
safe_free(results);
safe_free(offsets);
}
Expand All @@ -253,6 +304,9 @@ int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
offsets[i] = fuzz_consume_u64_in_range(&input, 0, MAX_BIT_OFFSET_64);
}
bitmap64_clearbits(bitmap, n_offsets, offsets);
for (size_t i = 0; i < n_offsets; i++) {
fuzz_require(!bitmap64_getbit(bitmap, offsets[i]));
}
safe_free(offsets);
}
break;
Expand All @@ -265,7 +319,11 @@ int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
for (size_t i = 0; i < n_offsets && fuzz_input_remaining(&input) > sizeof(uint64_t); i++) {
offsets[i] = fuzz_consume_u64_in_range(&input, 0, MAX_BIT_OFFSET_64);
}
bitmap64_clearbits_count(bitmap, n_offsets, offsets);
uint64_t pre_card = bitmap64_get_cardinality(bitmap);
size_t removed = bitmap64_clearbits_count(bitmap, n_offsets, offsets);
uint64_t post_card = bitmap64_get_cardinality(bitmap);
fuzz_require(pre_card >= post_card);
fuzz_require(pre_card - post_card == removed);
safe_free(offsets);
}
break;
Expand Down Expand Up @@ -294,7 +352,12 @@ int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
uint64_t offset = fuzz_consume_u64_in_range(&input, 0, MAX_BIT_OFFSET_64);
bitmap64_setbit(bitmap2, offset, true);
}
bitmap64_jaccard(bitmap, bitmap2);
double jaccard = bitmap64_jaccard(bitmap, bitmap2);
if (bitmap64_is_empty(bitmap) && bitmap64_is_empty(bitmap2)) {
fuzz_require(jaccard == -1);
} else {
fuzz_require(jaccard >= 0.0 && jaccard <= 1.0);
}
bitmap64_free(bitmap2);
}
break;
Expand Down
77 changes: 69 additions & 8 deletions tests/fuzz/fuzz_bitmap_api.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,14 @@ int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {

switch (op) {
case OP_SETBIT: {
uint32_t offset = fuzz_consume_u32_in_range(&input, 0, MAX_BIT_OFFSET_32);
uint32_t offset = fuzz_consume_bool(&input)
? 0
: fuzz_consume_u32_in_range(&input, 0, MAX_BIT_OFFSET_32);
bool value = fuzz_consume_bool(&input);
bitmap_setbit(bitmap, offset, value);
bool prev = bitmap_getbit(bitmap, offset);
bool ret = bitmap_setbit(bitmap, offset, value);
fuzz_require(ret == prev);
fuzz_require(bitmap_getbit(bitmap, offset) == value);
break;
}

Expand All @@ -49,6 +54,11 @@ int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
size_t array_size;
uint32_t* array = generate_uint32_array(&input, &array_size);
if (array && array_size > 0) {
if (fuzz_consume_bool(&input)) {
array[0] = 0;
if (array_size > 1) array[1] = 8;
if (array_size > 2) array[2] = 16;
}
Bitmap* new_bitmap = bitmap_from_int_array(array_size, array);
if (new_bitmap) {
bitmap_free(bitmap);
Expand All @@ -65,6 +75,9 @@ int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
if (card > 0 && card < MAX_SAFE_CARDINALITY) {
size_t result_size;
uint32_t* result = bitmap_get_int_array(bitmap, &result_size);
if (card <= MAX_RANGE_VALIDATE_CARDINALITY) {
fuzz_check_int_array32(bitmap, result, result_size);
}
safe_free(result);
}
break;
Expand All @@ -74,6 +87,11 @@ int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
size_t array_size;
uint32_t* array = generate_uint32_array(&input, &array_size);
if (array && array_size > 0) {
if (fuzz_consume_bool(&input)) {
array[0] = 0;
if (array_size > 1) array[1] = 8;
if (array_size > 2) array[2] = 16;
}
Bitmap* new_values = bitmap_from_int_array(array_size, array);
if (new_values) {
roaring_bitmap_or_inplace(bitmap, new_values);
Expand All @@ -87,10 +105,18 @@ int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
case OP_RANGEINTARRAY: {
uint64_t card = bitmap_get_cardinality(bitmap);
if (card > 0) {
size_t start = fuzz_consume_size_in_range(&input, 0, card);
size_t end = fuzz_consume_size_in_range(&input, start, card + 100);
size_t start = 0;
size_t end = 0;
if ((card >= 3) && fuzz_consume_bool(&input)) {
start = 0;
end = 2;
} else {
start = fuzz_consume_size_in_range(&input, 0, (size_t)card);
end = fuzz_consume_size_in_range(&input, start, (size_t)card + 100);
}
size_t result_count;
uint32_t* result = bitmap_range_int_array(bitmap, start, end, &result_count);
fuzz_check_range_int_array32(bitmap, start, end, result, result_count);
safe_free(result);
}
break;
Expand All @@ -102,6 +128,9 @@ int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
if (bit_array && bit_array_size > 0) {
Bitmap* new_bitmap = bitmap_from_bit_array(bit_array_size, bit_array);
if (new_bitmap) {
if (bit_array_size <= MAX_BITARRAY_VALIDATE_SIZE) {
fuzz_check_input_bit_array32(new_bitmap, bit_array, bit_array_size);
}
bitmap_free(bitmap);
bitmap = new_bitmap;
}
Expand All @@ -117,6 +146,9 @@ int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
if (max_val < MAX_BIT_OFFSET_32) {
size_t result_size;
char* bit_array = bitmap_get_bit_array(bitmap, &result_size);
if (result_size <= MAX_BITARRAY_VALIDATE_SIZE) {
fuzz_check_bit_array32(bitmap, bit_array, result_size);
}
bitmap_free_bit_array(bit_array);
}
}
Expand Down Expand Up @@ -195,14 +227,26 @@ int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {

case OP_MIN: {
if (!bitmap_is_empty(bitmap)) {
bitmap_min(bitmap);
uint32_t min = bitmap_min(bitmap);
uint64_t card = bitmap_get_cardinality(bitmap);
if (card > 0 && card <= MAX_RANGE_VALIDATE_CARDINALITY) {
int64_t expected = bitmap_get_nth_element_present(bitmap, 1);
fuzz_require(expected >= 0);
fuzz_require(min == (uint32_t)expected);
}
}
break;
}

case OP_MAX: {
if (!bitmap_is_empty(bitmap)) {
bitmap_max(bitmap);
uint32_t max = bitmap_max(bitmap);
uint64_t card = bitmap_get_cardinality(bitmap);
if (card > 0 && card <= MAX_RANGE_VALIDATE_CARDINALITY) {
int64_t expected = bitmap_get_nth_element_present(bitmap, card);
fuzz_require(expected >= 0);
fuzz_require(max == (uint32_t)expected);
}
}
break;
}
Expand Down Expand Up @@ -239,6 +283,11 @@ int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
offsets[i] = fuzz_consume_u32_in_range(&input, 0, MAX_BIT_OFFSET_32);
}
bool* results = bitmap_getbits(bitmap, n_offsets, offsets);
if (results) {
for (size_t i = 0; i < n_offsets; i++) {
fuzz_require(results[i] == bitmap_getbit(bitmap, offsets[i]));
}
}
safe_free(results);
safe_free(offsets);
}
Expand All @@ -253,6 +302,9 @@ int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
offsets[i] = fuzz_consume_u32_in_range(&input, 0, MAX_BIT_OFFSET_32);
}
bitmap_clearbits(bitmap, n_offsets, offsets);
for (size_t i = 0; i < n_offsets; i++) {
fuzz_require(!bitmap_getbit(bitmap, offsets[i]));
}
safe_free(offsets);
}
break;
Expand All @@ -265,7 +317,11 @@ int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
for (size_t i = 0; i < n_offsets && fuzz_input_remaining(&input) > sizeof(uint32_t); i++) {
offsets[i] = fuzz_consume_u32_in_range(&input, 0, MAX_BIT_OFFSET_32);
}
bitmap_clearbits_count(bitmap, n_offsets, offsets);
uint64_t pre_card = bitmap_get_cardinality(bitmap);
size_t removed = bitmap_clearbits_count(bitmap, n_offsets, offsets);
uint64_t post_card = bitmap_get_cardinality(bitmap);
fuzz_require(pre_card >= post_card);
fuzz_require(pre_card - post_card == removed);
safe_free(offsets);
}
break;
Expand Down Expand Up @@ -294,7 +350,12 @@ int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
uint32_t offset = fuzz_consume_u32_in_range(&input, 0, MAX_BIT_OFFSET_32);
bitmap_setbit(bitmap2, offset, true);
}
bitmap_jaccard(bitmap, bitmap2);
double jaccard = bitmap_jaccard(bitmap, bitmap2);
if (bitmap_is_empty(bitmap) && bitmap_is_empty(bitmap2)) {
fuzz_require(jaccard == -1);
} else {
fuzz_require(jaccard >= 0.0 && jaccard <= 1.0);
}
bitmap_free(bitmap2);
}
break;
Expand Down
24 changes: 24 additions & 0 deletions tests/fuzz/fuzz_bitmap_operations.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,18 @@ int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {

bitmap_free(intersection);
}
if (bitmap_get_cardinality(result) <= MAX_RANGE_VALIDATE_CARDINALITY) {
size_t result_len = 0;
uint32_t* result_array = bitmap_get_int_array(result, &result_len);
if (result_array) {
for (size_t i = 0; i < result_len; i++) {
for (int j = 0; j < num_inputs; j++) {
fuzz_require(bitmap_getbit(inputs[j], result_array[i]));
}
}
safe_free(result_array);
}
}
break;

case OP_FUZZ_OR:
Expand All @@ -165,6 +177,18 @@ int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
/* Invariant violation (shouldn't happen) */
}
}
for (int i = 0; i < num_inputs; i++) {
if (bitmap_get_cardinality(inputs[i]) <= MAX_RANGE_VALIDATE_CARDINALITY) {
size_t input_len = 0;
uint32_t* input_array = bitmap_get_int_array(inputs[i], &input_len);
if (input_array) {
for (size_t j = 0; j < input_len; j++) {
fuzz_require(bitmap_getbit(result, input_array[j]));
}
safe_free(input_array);
}
}
}
break;

case OP_FUZZ_XOR:
Expand Down
Loading