-
Notifications
You must be signed in to change notification settings - Fork 107
Upgrade to react 19 #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Upgrade to react 19 #425
Conversation
Phylum OSS Supply Chain Risk Analysis - FAILEDThis repository analyzes the risk of new dependencies. An If you see this comment, one or more dependencies have failed Phylum's risk analysis. Package:
|
|
The lock file is generated using pnpm 7.30.0, not sure why it breaks builds. |
|
Hey @avkonst. Would you be able to take a look at this PR this week? |
|
Hi, thank you for contribution. I am not able to look at this week but will try on weekend or next week. Could you please investigate what changed in the rerender from 2 to 3? That will help a lot |
|
@avkonst do you need any help maybe? |
do not throw hookstate-109 in dev mode
Phylum OSS Supply Chain Risk Analysis - FAILEDThis repository analyzes the risk of new dependencies. An If you see this comment, one or more dependencies have failed Phylum's risk analysis. Package:
|
|
Hi @RomanHotsiy . Sorry for dropping the ball here, life carried over with changes and I am overloaded over the board now. If you can help that would be great. If you could investigate the remaining two tests failing, suggest a fix in PR and I will merge. If you would like to take more active role in the project. I am happy to share as well. |
|
Hi, I just cloned the repo with the PR, ran the tests (pnpm test) to see which tests fail. I got only one test failing - the last one in Error.tsx in core, starting on line 46: But this is caused by recent commit 22bc57a, which does NOT throw 109 in dev mode. If I revert to b271f18, all tests seem to pass. Maybe I'm doing something odd, but I see no problem with the current tests and the PR? If possible, can you direct me to the failing tests, I want to try and help :) Disclaimer: I'm no Hookstate source code expert, just use it in projects, and will be glad to see it support React 19. |
|
Thanks for helping. I believe PR needs to be rebased to the latest mainline
then run the tests. The expectation is the tests are passing.
Sorry guys, I was extremely busy with a start up, relocated recently to a
new city, all that makes it very difficult to give it time. Happy to merge
and release if you complete the PR.
…On Wed, Jan 21, 2026 at 5:15 AM gdenchev ***@***.***> wrote:
*gdenchev* left a comment (avkonst/hookstate#425)
<#425 (comment)>
Hi, I just cloned the repo with the PR, ran the tests (pnpm test) to see
which tests fail.
I got only one test failing - the last one in Error.tsx in core, starting
on line 46:
test('error: should not allow serialization of statelink', async () => {
But this is caused by recent commit 22bc57a
<22bc57a>,
which does NOT throw 109 in dev mode.
If I revert to b271f18
<b271f18>,
all tests seem to pass.
Maybe I'm doing something odd, but I see no problem with the current tests
and the PR?
If possible, can you direct me to the failing tests, I want to try and
help :)
Disclaimer: I'm no Hookstate source code expert, just use it in projects,
and will be glad to see it support React 19.
—
Reply to this email directly, view it on GitHub
<#425 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA6JSVKBOVXQBP77EYUM5SL4HZICLAVCNFSM6AAAAAB55EYP4CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTONZTG42TIMRSHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I also upgraded the testing library as the @testing-library/react-hooks is deprecated.
Fixes #423
A few notable changes:
useMemotypings in react changed sodepsargument can't be undefined anymore (I updated in the code)@testing-library/reactdoesn't returnerrorbut throws instead