Adjust text input design #4234
Open
Adjust text input design #4234
+2,010
−187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianthedev
requested changes
Jan 30, 2026
Collaborator
adrianthedev
left a comment
adrianthedev
left a comment
There was a problem hiding this comment.
- the text input size doesn't match figma. can you pease cehck the others too? (don't set the height. see what's wrong with the sizes (padding, line height, font-size))
- let's try to add the spinner element as an after element.
| attr_reader :loading | ||
|
|
||
| def loading? | ||
| !!Avo::ExecutionContext.new(target: loading, record: record, view: view, resource: resource).handle |
Collaborator
There was a problem hiding this comment.
Why the !!?
Suggested change
| !!Avo::ExecutionContext.new(target: loading, record: record, view: view, resource: resource).handle | |
| !!Avo::ExecutionContext.new(target: loading, record: record, view: view, resource: resource).handle |
| module IsLoading | ||
| extend ActiveSupport::Concern | ||
|
|
||
| attr_reader :loading |
Collaborator
There was a problem hiding this comment.
do we ever add this loading attribute? I don't recall having that.
Ideally, we should be triggering loading with just a class or HTML attribute, not by reloading the field from the server.
| <%= content %> | ||
| <div class="field-wrapper__input"> | ||
| <%= content %> | ||
| <%= tag.span class: "input__spinner", "aria-hidden": "true" if @field.loading? %> |
Collaborator
There was a problem hiding this comment.
Can we add the spinner as an after element and not have to depend on adding an extra element on the page?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
polish design specifications for text inputs based on figma https://www.figma.com/design/Enmp0p0u8wFG0SuysUDszX/Avo-Design-System?node-id=2934-86442&m=dev
Checklist:
Screenshots & recording