perf/perf_sdt_probe: enhance test to run all sdt events#2934
Merged
Naresh-ibm merged 1 commit intoavocado-framework-tests:masterfrom May 22, 2025
Merged
perf/perf_sdt_probe: enhance test to run all sdt events#2934Naresh-ibm merged 1 commit intoavocado-framework-tests:masterfrom
Naresh-ibm merged 1 commit intoavocado-framework-tests:masterfrom
Conversation
|
|
||
| def run_cmd(self, cmd): | ||
| if process.system(cmd, ignore_status=True, sudo=True, shell=True): | ||
| if process.system(cmd, sudo=True, shell=True): |
Member
There was a problem hiding this comment.
any reason to ignore_status=True to removig this
Contributor
Author
There was a problem hiding this comment.
If any perf sdt event fails, the test should fail. If we add ignore_status=True it will ignore the failure.
Naresh-ibm
reviewed
Mar 16, 2025
This patch adds logic to test all the SDT events present and later removes them. Also increase the sleep time to avoid failure in cases where perf list is not updated after adding probe. Signed-off-by: Disha Goel <disgoel@linux.ibm.com>
Naresh-ibm
approved these changes
May 22, 2025
Collaborator
Naresh-ibm
left a comment
Naresh-ibm
left a comment
There was a problem hiding this comment.
@disgoel Thanks for PR
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds logic to test all the SDT events present and later removes them.
Also increase the sleep time to avoid failure in cases where perf list is not updated after adding probe.
debug.log