Fixed uses of showing warnings in avocado misc tests. #2947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@SamirMulani please wrap both the commits in single commit |
In older versions of Avocado, the self.warn method was used to display warnings, and we adapted this approach when the API supported it. However, in the latest version of Avocado, warnings are now displayed using self.log.warn(), as warning messages have been incorporated into the logging class. We have adopted the same API in multiple test cases where we previously used the older method for displaying warnings. Signed-off-by: Samir Mulani <samir@linux.vnet.ibm.com> Fixed PEP8 compliance FAIL issue. Ran the autopep8 -i .py file to fix the style issue. Signed-off-by: Samir Mulani <samir@linux.vnet.ibm.com>
Collaborator
|
@SamirMulani can you please add runs logs for at. least couple of major test cases, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In older versions of Avocado, the self.warn method was used to display warnings, and we adapted this approach when the API supported it. However, in the latest version of Avocado, warnings are now displayed using self.log.warn(), as warning messages have been incorporated into the logging class. We have adopted the same API in multiple test cases where we previously used the older method for displaying warnings.