-
Notifications
You must be signed in to change notification settings - Fork 131
perf_report_options.py:: Added new testcase to run all present and less used options for perf report #3051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@Tejas3772 Can you please attach debug.log |
|
@Tejas3772 please address the review comment from @Naresh-ibm and wrap all the commits in logical commits (here, i feel it is one) |
7621c2e to
a68e030
Compare
|
excuse the Fail at -v and --verbose, fails at new 9.8 kernel manually with certain record options with seg fault |
|
Made code changes to run without yaml as well |
aff343b to
386d45e
Compare
|
your code is considering --branch-filter also as a report option to test which is not true and fails with 129 exit code. This should fail, instead of adding in unknown options list. Please fix the logic to parse report options. same with --data also |
eda3bef to
e80ddc8
Compare
…used options for perf report Implemented a new Avocado testcase to validate perf report options. The testcase runs perf report with both documented and less frequently used/unused options, capturing output and errors for each. Signed-off-by: Tejas Manhas <[email protected]>
|
Actually it happened because while picking, description record options got picked, fixed that, this logic is intact as that options unknown for report so it will give unknown option only. Fixed at the correct function. |
| @@ -0,0 +1,56 @@ | |||
| --prefix: "/home/user/src" | |||
| --prefix - strip: "1" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix this also
| pass | ||
| self.buldir = smg.get_source( | ||
| src_name, self.workdir, build_option='-bp') | ||
| self.buldir = os.path.join(self.buldir, os.listdir(self.buldir)[0]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add logic to handle this error
FileNotFoundError: [Errno 2] No such file or directory: ''
| self.perf_src_options = self.get_src_options() | ||
| self.log.info(f"Perf report source options: {self.perf_src_options}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you fix parsing logic, some are not report options
[stdlog] 2025-11-20 23:50:47,694 avocado.test perf_report L0074 INFO | Perf report source options: {'-639', '--itrace', '-2025-11-20T23', '-t', '--dump', '-D', '-a2086bd', '-clock', '-fvt-wrapper', '-o-', '-q', '-i', '-s', '--task', '-e', '--header', '--percent-limit', '-5', '--stdio', '-perf_report', '-g', '-n', '-results', '-E', '-i-', '-A', '--header-only', '-F', '-o', '--stitch-lbr'}
Implemented a new Avocado testcase to validate perf report options. The testcase runs perf report with both documented and less frequently used/unused options, capturing output and errors for each.