Skip to content

Conversation

@SamirMulani
Copy link
Contributor

Previously, the code used a hard-coded SOS NUMA plugin name (numa1). However, some distributions do not provide the numa1 plugin and instead use numa. This commit adds logic to dynamically detect the supported NUMA plugin for the running distribution. With this change, the correct plugin name (numa1 or numa) is selected automatically at runtime, improving portability across distros.

@SamirMulani
Copy link
Contributor Author

Run Logs:
avocado run sosreport.py:Sosreport.test_others
JOB ID : 63d2317c2ac235acb5a59d14692d96a06e0e3ba4
JOB LOG : /root/avocado-fvt-wrapper/results/job-2025-11-20T18.30-63d2317/job.log
(1/1) sosreport.py:Sosreport.test_others: STARTED
(1/1) sosreport.py:Sosreport.test_others: PASS (553.71 s)
RESULTS : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /root/avocado-fvt-wrapper/results/job-2025-11-20T18.30-63d2317/results.html
JOB TIME : 570.90 s

@Naresh-ibm Naresh-ibm self-assigned this Nov 20, 2025
ras/sosreport.py Outdated
match = re.match(r"^(\w+)\s+(.*)$", plugins.strip())
if match:
matched_plugin = match.group(1)
break
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this break in second if loop?
I feel something not in proper index.

Copy link
Contributor

@sacsant sacsant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rewrite the commit message in a proper format, explaining what the problem is and how this change fixes the problem. Also merge the 2 commits into one. I assume the second commit was added to address review comments.

Previously, the code used a hard-coded SOS NUMA plugin name (numa1).
However, some distributions do not provide the numa1 plugin and instead use numa.
This commit adds logic to dynamically detect the supported NUMA plugin for the running distribution.
With this change, the correct plugin name (numa1 or numa) is selected automatically at runtime, improving portability across distros.

Signed-off-by: “Samir <“samir@linux.ibm.com”>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants