Skip to content

Added adapter details update and improve DRC validation #3071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maramsmurthy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added adapter details update and improve DRC validation #3071

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion io/pci/dlpar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@ def test_dlpar(self):
for _ in range(self.num_of_dlpar):
self.dlpar_remove()
self.dlpar_add()
self.set_adapter_details(pci)
self.validation_in_os(pci)
self.dlpar_move()

Expand All @@ -220,9 +221,11 @@ def test_drmgr_pci(self):
for _ in range(self.num_of_dlpar):
self.do_drmgr_pci('r')
self.do_drmgr_pci('a')
self.set_adapter_details(pci)
self.validation_in_os(pci)
for _ in range(self.num_of_dlpar):
self.do_drmgr_pci('R')
self.set_adapter_details(pci)
self.validation_in_os(pci)

def test_drmgr_phb(self):
Expand All @@ -234,6 +237,7 @@ def test_drmgr_phb(self):
for _ in range(self.num_of_dlpar):
self.do_drmgr_phb('r')
self.do_drmgr_phb('a')
self.set_adapter_details(pci)
Copy link
Collaborator

@Naresh-ibm Naresh-ibm Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maramsmurthy where are we adding the details for /dev/disk/by-id/

Copy link
Contributor Author

@maramsmurthy maramsmurthy Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naresh-ibm

I hope we no need to perform /dev/disk/by-id as it is just needed a namespace check.

Name space check is already available as follows in dlpar.py only

        current_namespaces = nvme.get_current_ns_ids(self.contr_name)
        if current_namespaces == self.ns_list:
            for ns_id in current_namespaces:
                status = nvme.get_ns_status(self.contr_name, ns_id)
                if not status[0] == 'live' and status[1] == 'optimized':
                    err_ns.append(ns_id)
        else:
            self.log.info("following ns not back listing after hot_plug" %
                          (self.ns_list - current_namespaces))

Please check and let me know if any other changes are required.

self.validation_in_os(pci)

def do_drmgr_pci(self, operation):
Expand Down Expand Up @@ -270,7 +274,7 @@ def dlpar_remove(self):
self.changehwres(self.server, 'r', self.lpar_id, self.lpar_1,
self.drc_index, 'remove')
output = self.listhwres(self.server, self.lpar_1, self.drc_index)
if output:
if output and ",drc_index="+self.drc_index in output:
self.log.debug(output)
self.fail("lshwres still lists the drc after dlpar remove")

Expand Down
Loading