lsvpd validation for spyre #3078
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sai Janani C <jananic@linux.ibm.com>
Signed-off-by: Sai Janani C <jananic@linux.ibm.com>
abdhaleegit
requested changes
Jan 8, 2026
Collaborator
abdhaleegit
left a comment
abdhaleegit
left a comment
There was a problem hiding this comment.
- commit description missing
- run Logs missing
- please remove sosreport commit form this pr
- lot of syntax issue.. please fix
| self.fail(f"Errors for above pci addresses: {error}") | ||
|
|
||
| def test_spyre_lsvpd_validation(self): | ||
| if process.system("vpdupdate", ignore_status=True, shell=True): |
Collaborator
There was a problem hiding this comment.
Indentation messed up.. please fix it
| with open(cls) as f: | ||
| if f.read().strip().startswith('0x1200'): | ||
| spyre_devices.append(dev) | ||
| except Exception: |
Collaborator
There was a problem hiding this comment.
Reuse the avocado utils get_pci_class method
| sysfs_subvendor = self.run_cmd_out( | ||
| f"cat /sys/bus/pci/devices/{dev}/subsystem_vendor").strip() | ||
| sysfs_subdevice = self.run_cmd_out( | ||
| f"cat /sys/bus/pci/devices/{dev}/subsystem_device").strip() |
|
|
||
| spyre_block = [] | ||
| capture = False | ||
| for line in lsvpd_out.splitlines(): |
| self.fail(f"Invalid EC value for Spyre device {dev}") | ||
|
|
||
| if not fw_vpd: | ||
| self.fail(f"Firmware value missing for Spyre device {dev}") |
Collaborator
There was a problem hiding this comment.
optimize .. may be loop ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.