-
Notifications
You must be signed in to change notification settings - Fork 34
Emit a helpful logging message on reused object server #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Emit a helpful logging message on reused object server #163
Conversation
WalkthroughAn info log message was added in Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
aexpect/remote_door.py (1)
625-629: Consider usingLOG.info()instead ofLOG.warning()for routine server reuse.The log message describes a normal operational scenario—successfully binding to an existing server—rather than a warning condition. Using
LOG.warning()here may clutter warning logs with informational messages that don't indicate problems.🔎 Proposed change to use INFO level
remote_object = Pyro4.Proxy(f"PYRONAME:{object_name}@{host}:{port}") # noinspection PyProtectedMember remote_object._pyroBind() - LOG.warning("Previous remote object server running, reusing it as is") + LOG.info("Previous remote object server running, reusing it as is")
Signed-off-by: Plamen Dimitrov <plamen.dimitrov@intra2net.com>
5b92f33 to
af49596
Compare
| remote_object = Pyro4.Proxy(f"PYRONAME:{object_name}@{host}:{port}") | ||
| # noinspection PyProtectedMember | ||
| remote_object._pyroBind() | ||
| LOG.info("Previous remote object server running, reusing it as is") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't debug loglevel suffice here?
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.