nrunner: reorganization of unittests#5966
Merged
richtja merged 4 commits intoavocado-framework:masterfrom Jul 12, 2024
Merged
Conversation
clebergnu
force-pushed
the
unittest_nrunner_reorg
branch
3 times, most recently
from
f165220 to
597a771
Compare
richtja
requested changes
Jun 27, 2024
Contributor
richtja
left a comment
richtja
left a comment
There was a problem hiding this comment.
Hi @clebergnu, the overall changes LGTM. I have just one proposal about removing some tests, but we can merge it without it. And one proposal to commit format which would help me to finish the review.
clebergnu
force-pushed
the
unittest_nrunner_reorg
branch
2 times, most recently
from
a468d77 to
68f5f5e
Compare
richtja
requested changes
Jul 10, 2024
Contributor
richtja
left a comment
richtja
left a comment
There was a problem hiding this comment.
Hi @clebergnu, thank you for your updates. I have one more comment to the runner_tap.py path. Please let me know what do you think.
The temp directory is being used simply to hold the content of runnable recipes (JSON files) which are created by means of Runnable.write_json(). But, Runnable.write_json() itself is utter uninteresting, being simply a convenience around Runnable.get_json(). Signed-off-by: Cleber Rosa <crosa@redhat.com>
This avoids some codepaths that can mock the loading of the JSON schema, instead of the opening of the recipe file. Signed-off-by: Cleber Rosa <crosa@redhat.com>
There are some "blind spots" in the runnable code, such as when dealing with serialization from JSON files and Runnable's configuration. To allow for a clearer view of the current coverage of Runnable's features, let's reorganize their tests in a file of its own, and based on the usage and where the data is coming from or going to. Signed-off-by: Cleber Rosa <crosa@redhat.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>
clebergnu
force-pushed
the
unittest_nrunner_reorg
branch
from
68f5f5e to
c97ca92
Compare
richtja
approved these changes
Jul 12, 2024
Contributor
richtja
left a comment
richtja
left a comment
There was a problem hiding this comment.
After the changes it LGTM, thanks @clebergnu.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some "blind spots" in the runnable code, such as when dealing with serialization from JSON files and Runnable's configuration.
To allow for a clearer view of the current coverage of Runnable's features, let's reorganize their tests in a file of its own, and based on the usage and where the data is coming from or going to.