Save app config on exit to persist changes made shortly before closing#66
Open
mmotorny wants to merge 1 commit intoavsaase:masterfrom
Open
Save app config on exit to persist changes made shortly before closing#66mmotorny wants to merge 1 commit intoavsaase:masterfrom
mmotorny wants to merge 1 commit intoavsaase:masterfrom
Conversation
Contributor
Author
|
CI is broken by unrelated linter errors. I sent another PR to fix them first: #67 |
Contributor
Author
|
Now that #67 has been merged, please re-run checks and accept this PR. |
Owner
|
You first need to rebase this on |
Config was only saved after a 2-second debounce. Changes made right before exiting (e.g. toggling GBat or other SRT options) were lost. Implement on_exit() to save config unconditionally when the app shuts down. Made-with: Cursor
mmotorny
force-pushed
the
fix/app-config-persistence-on-exit
branch
from
7f5eb39 to
16bff22
Compare
Contributor
Author
|
I apologize, Alexander, it wasn't my intention to sound rude! Thank you for taking time to review my PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config was only saved after a 2-second debounce. Changes made right before exiting (for example, toggling SRT options) were lost. Implement on_exit() to save config unconditionally when the app shuts down.
Made-with: Cursor