Remove Anonymous constructor from DotProtoIdentifier#294
Open
Remove Anonymous constructor from DotProtoIdentifier#294
Anonymous constructor from DotProtoIdentifier#294Conversation
j6carey
reviewed
Nov 18, 2025
| default-extensions: | ||
| BlockArguments ExplicitNamespaces DeriveDataTypeable DeriveGeneric | ||
| ImportQualifiedPost ViewPatterns | ||
| ImportQualifiedPost PatternSynonyms ViewPatterns |
Collaborator
There was a problem hiding this comment.
Need to go to v0.10.0 at least because of the AST changes.
j6carey
reviewed
Nov 18, 2025
| import Data.Data (Data) | ||
| import Data.Int (Int32) | ||
| import qualified Data.List.NonEmpty as NE | ||
| import Data.List.NonEmpty (NonEmpty (..)) |
Collaborator
There was a problem hiding this comment.
Unless and until we change the import style (which I'd be happy to do), we should probably keep the current indentation style.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes changes to the protobuf AST in order to remove some constructions which don't map to any meaningful protobuf syntax. Additionally, this PR will attempt to refactor how
DotProtoIdentifieris defined so that it is no longer a recursive type, but a record with fields for enclosing file path, qualifiers, and the identifier symbol.