Fasten Ansible build progress#118
Open
YuxiangZhuang wants to merge 1 commit intoawesome-kyuubi:masterfrom
Open
Fasten Ansible build progress#118YuxiangZhuang wants to merge 1 commit intoawesome-kyuubi:masterfrom
YuxiangZhuang wants to merge 1 commit intoawesome-kyuubi:masterfrom
Conversation
Member
|
Encounter failures during manual verification. (Ubuntu 24.04, x64, Python 3.11, Ansible 2.15) |
pan3793
reviewed
Mar 24, 2025
| with_items: "{{ j2_files.files }}" | ||
|
|
||
| - name: orchestrate {{ node.name }} - {{ node.group }} - mkdir | ||
| - name: orchestrate {{ node.name }} - remove all j2 templates |
Member
There was a problem hiding this comment.
I don't get the idea of copying j2 templates to the destination first and deleting them eventually, why is it faster than in-place rendering?
pan3793
reviewed
Mar 24, 2025
| path: "{{ node.name }}/{{ item.path }}" | ||
| state: directory | ||
| with_community.general.filetree: "templates/hadoop-common" | ||
| when: item.state == "directory" |
Member
There was a problem hiding this comment.
this is definitely the most costly step, in my experiment, it costs 15.94s, so collecting and dedup the dirs first and only creating the unique dirs should be a good idea
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fasten Ansible build using ansible.builtin.shell instead of ansible.builtin.file in node-template.yml, and add .j2 prefix of all template file.
With test, the time cost of
ansible-playbook build.yamlreduce from about 59s to about 22s