Fix focus.global_bydirection not moving focus from empty screen #3815
Conversation
When having three monitors and only one client on the first monitor, the function does not work when the middle monitor is focused, as it uses the focused clients' screen instead of the currently focused screen as the base.
Codecov Report
@@ Coverage Diff @@
## master #3815 +/- ##
==========================================
+ Coverage 90.99% 91.02% +0.02%
==========================================
Files 900 901 +1
Lines 57506 57530 +24
==========================================
+ Hits 52329 52365 +36
+ Misses 5177 5165 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
The failing assertion seems to concern |
|
with 5.2 it's failing as well: https://github.com/awesomeWM/awesome/actions/runs/5039591637/jobs/9038043753?pr=3815 |
The first step would be to run the tests locally. |
|
Ok, didn't see that. That error is even weirder though, as it's in line 21 even before calling any of the focus functions.
Thanks for the hint. I unfortunately I have never used lua aside from my awesome config. Therefore I haven't got a local lua dev environment and wasn't able to set one up either because of 'lgi' being missing. I even tried installing lgi by using the steps from the github actions file. I can't invest more time here, so feel free to close if nobody else is willing to take over. |
|
Given this other PR #3817 (that only changes unrelated documentation) has a similar CI fail (the fail is on the same test at least), I guess this is rather an instability in our CI. |
|
indeed it weirdly failed for both of them at the same time - but restarting helped for both |
4 participants
When having three monitors and only one client on the first monitor, the function does not work when the middle monitor is focused, as it uses the focused clients' screen instead of the currently focused screen as the base.