Deprecate awesome.load_image#3976
Conversation
| * awesome.pixbuf_to_surface | ||
| */ | ||
|
|
||
| luaA_deprecate(L, "awesome.pixbuf_to_surface"); |
There was a problem hiding this comment.
The suggestion for awesome.pixbuf_to_surface in that comment has since become outdated as well. I think gears.surface would be a better suggestion.
There was a problem hiding this comment.
gears.surface uses awesome.pixbuf_to_surface internally, and I would argue that it's better to put a function as close to the replaced one in functionality in @deprecate
There was a problem hiding this comment.
Let's do it one step at a time, this will do.
|
@Mergifyio rebase |
Signed-off-by: delta <darkussdelta@gmail.com>
✅ Branch has been successfully rebased |
Aire-One
force-pushed
the
load_image_deprecate
branch
from
51b98dc to
e71e5de
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3976 +/- ##
===========================================
+ Coverage 54.48% 90.41% +35.93%
===========================================
Files 264 938 +674
Lines 31218 60252 +29034
Branches 1139 1139
===========================================
+ Hits 17009 54478 +37469
+ Misses 13703 5268 -8435
Partials 506 506
🚀 New features to boost your workflow:
|
Funny... |
|
I went ahead and added a new |
4 participants
As it currently stands, both
luaA_load_imageanddraw_load_imageare left unused and only serve to padluaa.canddraw.crespectively. This PR deprecates the former to allow the eventual removal of both.