Menubar: Added theme.menubar_bg_base#4010
Open
SuperDuperDeou wants to merge 1 commit intoawesomeWM:masterfrom
Open
Menubar: Added theme.menubar_bg_base#4010SuperDuperDeou wants to merge 1 commit intoawesomeWM:masterfrom
SuperDuperDeou wants to merge 1 commit intoawesomeWM:masterfrom
Conversation
Aire-One
previously approved these changes
Oct 7, 2025
Member
Aire-One
left a comment
There was a problem hiding this comment.
@SuperDuperDeou can you please rebase for CI checks to pass?
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4010 +/- ##
==========================================
+ Coverage 54.25% 54.43% +0.18%
==========================================
Files 261 263 +2
Lines 31173 31218 +45
Branches 1143 1143
==========================================
+ Hits 16912 16993 +81
+ Misses 13751 13715 -36
Partials 510 510
🚀 New features to boost your workflow:
|
Aire-One
reviewed
Oct 8, 2025
Adding the theme.menubar_bg_base to lib/menubar/init.lua, this allows for the base widget to be drawn with a different background color than the items. This is especially useful with semitransparent themes to avoid unintentional alphas.
ccadbcd to
dd3e9cf
Compare
actionless
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the theme.menubar_bg_base to lib/menubar/init.lua, this allows for the base widget to be drawn with a different background color than the items. This is especially useful with semitransparent themes to avoid unintentional alphas.