Skip to content

Conversation

@JimmyCozza
Copy link

…el colors

Add beautiful.hotkeys_override_label_bgs option that, when set to true, applies hotkeys_label_bg to all group labels instead of cycling through xresources colors. This provides users with full control over label background colors for a more consistent appearance.

Fixes #3773

Aire-One
Aire-One previously approved these changes Oct 7, 2025
Copy link
Member

@Aire-One Aire-One left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JimmyCozza can you please rebase for the CI checks to pass?

…el colors

Add beautiful.hotkeys_override_label_bgs option that, when set to true,
applies hotkeys_label_bg to all group labels instead of cycling through
xresources colors. This provides users with full control over label
background colors for a more consistent appearance.

Fixes awesomeWM#3773
Signed-off-by: Jimmy Cozza <[email protected]>
@JimmyCozza JimmyCozza force-pushed the hotkeys_popup_colors branch from 2c8cbc5 to 670eff9 Compare October 10, 2025 04:53
@JimmyCozza
Copy link
Author

@Aire-One I rebased and force pushed. Still not seeing the CI checks running, but I wonder if that's because I'm a new contributor and need the approval for workflows.

Either way, let me know if there's anything more I can do here.

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.53%. Comparing base (7263f64) to head (29dd7e7).

Files with missing lines Patch % Lines
lib/awful/hotkeys_popup/widget.lua 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4017      +/-   ##
==========================================
+ Coverage   54.41%   54.53%   +0.12%     
==========================================
  Files         264      263       -1     
  Lines       31259    31263       +4     
  Branches     1149     1149              
==========================================
+ Hits        17009    17049      +40     
+ Misses      13739    13703      -36     
  Partials      511      511              
Files with missing lines Coverage Δ
lib/awful/hotkeys_popup/widget.lua 40.93% <0.00%> (-0.65%) ⬇️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Aire-One
Copy link
Member

@Aire-One I rebased and force pushed. Still not seeing the CI checks running, but I wonder if that's because I'm a new contributor and need the approval for workflows.

Either way, let me know if there's anything more I can do here.

Yes, we need to approve for the CI to run on new contributors PRs.

Checking lib/awful/hotkeys_popup/widget.lua       1 warning

    lib/awful/hotkeys_popup/widget.lua:294:121: line is too long (126 > 120)

This will need to be fixed.

…el colors

Add beautiful.hotkeys_override_label_bgs option that, when set to true,
applies hotkeys_label_bg to all group labels instead of cycling through
xresources colors. This provides users with full control over label
background colors for a more consistent appearance.

Fixes awesomeWM#3773
Signed-off-by: Jimmy Cozza <[email protected]>
@JimmyCozza JimmyCozza force-pushed the hotkeys_popup_colors branch from d1ade28 to e148e50 Compare October 10, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User cannot specify hotkeys_popup label background colors

2 participants