-
Notifications
You must be signed in to change notification settings - Fork 624
feat(hotkeys_popup): add override_label_bgs option for consistent lab… #4017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JimmyCozza can you please rebase for the CI checks to pass?
…el colors Add beautiful.hotkeys_override_label_bgs option that, when set to true, applies hotkeys_label_bg to all group labels instead of cycling through xresources colors. This provides users with full control over label background colors for a more consistent appearance. Fixes awesomeWM#3773 Signed-off-by: Jimmy Cozza <[email protected]>
2c8cbc5 to
670eff9
Compare
|
@Aire-One I rebased and force pushed. Still not seeing the CI checks running, but I wonder if that's because I'm a new contributor and need the approval for workflows. Either way, let me know if there's anything more I can do here. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4017 +/- ##
==========================================
+ Coverage 54.41% 54.53% +0.12%
==========================================
Files 264 263 -1
Lines 31259 31263 +4
Branches 1149 1149
==========================================
+ Hits 17009 17049 +40
+ Misses 13739 13703 -36
Partials 511 511
🚀 New features to boost your workflow:
|
Yes, we need to approve for the CI to run on new contributors PRs. This will need to be fixed. |
…el colors Add beautiful.hotkeys_override_label_bgs option that, when set to true, applies hotkeys_label_bg to all group labels instead of cycling through xresources colors. This provides users with full control over label background colors for a more consistent appearance. Fixes awesomeWM#3773 Signed-off-by: Jimmy Cozza <[email protected]>
…into hotkeys_popup_colors
d1ade28 to
e148e50
Compare
…el colors
Add beautiful.hotkeys_override_label_bgs option that, when set to true, applies hotkeys_label_bg to all group labels instead of cycling through xresources colors. This provides users with full control over label background colors for a more consistent appearance.
Fixes #3773