Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4062 +/- ##
==========================================
+ Coverage 90.44% 90.47% +0.02%
==========================================
Files 939 939
Lines 60346 60342 -4
Branches 1145 1145
==========================================
+ Hits 54582 54592 +10
+ Misses 5254 5243 -11
+ Partials 510 507 -3
🚀 New features to boost your workflow:
|
Elv13
reviewed
Mar 8, 2026
| .data32 = { | ||
| globalconf.timestamp, | ||
| globalconf.systray.atom, | ||
| globalconf.systray.window, |
Member
There was a problem hiding this comment.
Should there be a NULL, NULL here to be like the old code?
Contributor
Author
There was a problem hiding this comment.
No, when using an initializer, fields that are not specified for initialization will be set to 0, which is NULL.
Member
There was a problem hiding this comment.
@Elv13 do you mean to explicitly populate every slot, since the field is defined as uint32_t data32[5] by xcb? I would second this, as a general good practice for code maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.