Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4063 +/- ##
==========================================
+ Coverage 90.47% 90.52% +0.04%
==========================================
Files 940 938 -2
Lines 60359 60273 -86
Branches 1145 1132 -13
==========================================
- Hits 54609 54560 -49
+ Misses 5243 5217 -26
+ Partials 507 496 -11
🚀 New features to boost your workflow:
|
3028f6d to
147b960
Compare
Member
|
although it now conflicts with another your PR which got merged earlier |
actionless
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buffer_t is a string type, and glib provides a ready-made GString implementation. We don't need to maintain our own.
Our buffer_t also handles stack allocation. When stack allocation is required, I use a variable-length array as a replacement.