Skip to content

refactor: optmize luaA_class_setup#4073

Open
cnjhb wants to merge 1 commit intoawesomeWM:masterfrom
cnjhb:createtable
Open

refactor: optmize luaA_class_setup#4073
cnjhb wants to merge 1 commit intoawesomeWM:masterfrom
cnjhb:createtable

Conversation

@cnjhb
Copy link
Copy Markdown
Contributor

@cnjhb cnjhb commented Mar 2, 2026

The new luaA_class_setup preallocates the table, resulting in faster performance.
However, it can only accept arrays for methods and meta. Fortunately, all our luaA_class_setup use cases involve passing arrays.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.46%. Comparing base (39143f0) to head (1381e18).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4073      +/-   ##
==========================================
+ Coverage   90.44%   90.46%   +0.01%     
==========================================
  Files         939      939              
  Lines       60346    60350       +4     
  Branches     1145     1145              
==========================================
+ Hits        54582    54594      +12     
+ Misses       5254     5249       -5     
+ Partials      510      507       -3     
Files with missing lines Coverage Δ
common/luaclass.c 87.89% <100.00%> (+0.19%) ⬆️
common/luaclass.h 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@actionless actionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants