Do not update shapes on property::size#4093
Open
DziubanMaciej wants to merge 1 commit intoawesomeWM:masterfrom
Open
Do not update shapes on property::size#4093DziubanMaciej wants to merge 1 commit intoawesomeWM:masterfrom
DziubanMaciej wants to merge 1 commit intoawesomeWM:masterfrom
Conversation
The internal::update_shapes signal will be emitted by client_refresh which does it. Also, delay it until next frame. For some reason updating shapes directly within client_refresh introduces some flicker
597f1ee to
f7a98ce
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4093 +/- ##
==========================================
+ Coverage 90.45% 90.47% +0.01%
==========================================
Files 941 941
Lines 60390 60394 +4
Branches 1145 1145
==========================================
+ Hits 54628 54640 +12
+ Misses 5252 5247 -5
+ Partials 510 507 -3
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The internal::update_shapes signal will be emitted by client_refresh which does it. Also, delay it until next frame. For some reason updating shapes directly within client_refresh introduces some flicker